[breaking] move BenchmarkTools.jl to a package extension#2982
Merged
Conversation
This is a breaking change because it requires the user to install and load BenchmarkTools.jl. We justify releasing it in a minor release of MathOptInterface because we assess that there are very few users of it, and because it should be used only during package development by advanced users. We reserve the right to revert this commit in a future release of MOI if it causes problems in the ecosystem.
Member
Author
|
Merging so I can rebase #2967 which will have some conflicts. There's no rush to tag a new version once this is merged. |
Contributor
|
Why not bump the major if it is theoretically breaking? edit: To elaborate my point a little bit: developers are a bit too scared to bump the major number. From my point of view, if you are aware that something is breaking you should bump the major, that's a feature of SemVer, that's not something to be scared of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change because it requires the user to install and load BenchmarkTools.jl.
We justify releasing it in a minor release of MathOptInterface because we assess that there are very few users of it, and because it should be used only during package development by advanced users.
We reserve the right to revert this commit in a future release of MOI if it causes problems in the ecosystem.
Closes #2728